-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WooCommerce Analytics: require package in the Jetpack plugin #35758
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
b035cbb
to
7848763
Compare
Fixes #35630 This brings in the codebase from the Jetpack module to the package. In the process: - It adds new package dependencies instead of relying on Jetpack classes. - It moves away from a singleton.
7848763
to
3009e61
Compare
See #35756 (comment) Co-authored-by: Juanma Rodriguez Escriche <juanma.rodriguez.escriche@automattic.com>
Fixes #35631 Let's require the WooCommerce Analytics package in the Jetpack plugin, and mark the existing codebase in the Jetpack plugin as deprecated.
26e7a29
to
73e2966
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jeherve - seems like the package is loading ok, but the stats file loaded for me is s-202409.js
which does not fit the year/month (but it does fit year/week, is that what it's using?).
Also, this one is for @senadir not you but it seems that when using the cart block, the values below are incorrectly reported on all events:
cart_page_contains_cart_block: 0
cart_page_contains_cart_shortcode: 1
Nadir can you replicate/see the cause?
Requesting changes so we can update the PR description or look into the stats JS file, thanks!
Yes sorry, that's what I should have written. jetpack/projects/packages/woocommerce-analytics/src/class-woocommerce-analytics.php Line 98 in fa0dba9
I've updated the PR description accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. I ran the tests using both trunk
and this branch. Track events generated as expected throughout the browsing, adding to cart, and checking out flow on each branch.
I approve. Thanks for the work on this Jeremy.
Changes were addressed in the PR description
Fixes #35631
Proposed changes:
Important
Do not merge this PR until #35754, #35756, and #35857 get merged.
Let's require the WooCommerce Analytics package in the Jetpack plugin, and mark the existing codebase in the Jetpack plugin as deprecated.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: