Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WooCommerce Analytics: require package in the Jetpack plugin #35758

Merged
merged 10 commits into from
Mar 8, 2024

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Feb 19, 2024

Fixes #35631

Proposed changes:

Important

Do not merge this PR until #35754, #35756, and #35857 get merged.

Let's require the WooCommerce Analytics package in the Jetpack plugin, and mark the existing codebase in the Jetpack plugin as deprecated.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Pri] Normal [Feature] WooCommerce Analytics [Package] WooCommerce Analytics Enhanced analytics for WooCommerce users labels Feb 19, 2024
@jeherve jeherve self-assigned this Feb 19, 2024
Copy link
Contributor

github-actions bot commented Feb 19, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the require-wooanalytics-jetpack branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack require-wooanalytics-jetpack
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Feb 19, 2024
Copy link
Contributor

github-actions bot commented Feb 19, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for April 2, 2024 (scheduled code freeze on April 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jeherve jeherve force-pushed the add/codebase-woo-analytics branch 2 times, most recently from b035cbb to 7848763 Compare February 20, 2024 10:02
Fixes #35630

This brings in the codebase from the Jetpack module to the package.
In the process:

- It adds new package dependencies instead of relying on Jetpack classes.
- It moves away from a singleton.
jeherve and others added 3 commits February 21, 2024 13:49
See #35756 (comment)

Co-authored-by: Juanma Rodriguez Escriche <juanma.rodriguez.escriche@automattic.com>
Fixes #35631

Let's require the WooCommerce Analytics package in the Jetpack plugin, and mark the existing codebase in the Jetpack plugin as deprecated.
Base automatically changed from add/codebase-woo-analytics to trunk February 21, 2024 13:17
@jeherve
Copy link
Member Author

jeherve commented Feb 21, 2024

@senadir @opr Do you think you could give this PR a try, and see that existing WooCommerce Analytics functionality still works? It does seem to work on my end, but I think you're a lot more familiar with the feature than I am.

Thank you!

opr
opr previously requested changes Feb 27, 2024
Copy link
Contributor

@opr opr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jeherve - seems like the package is loading ok, but the stats file loaded for me is s-202409.js which does not fit the year/month (but it does fit year/week, is that what it's using?).

Also, this one is for @senadir not you but it seems that when using the cart block, the values below are incorrectly reported on all events:

cart_page_contains_cart_block: 0
cart_page_contains_cart_shortcode: 1

Nadir can you replicate/see the cause?

Requesting changes so we can update the PR description or look into the stats JS file, thanks!

@jeherve
Copy link
Member Author

jeherve commented Feb 27, 2024

it does fit year/week, is that what it's using?

Yes sorry, that's what I should have written.

I've updated the PR description accordingly.

@chrisbliss18 chrisbliss18 self-requested a review March 7, 2024 19:14
Copy link
Contributor

@chrisbliss18 chrisbliss18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I ran the tests using both trunk and this branch. Track events generated as expected throughout the browsing, adding to cart, and checking out flow on each branch.

I approve. Thanks for the work on this Jeremy.

@jeherve jeherve dismissed opr’s stale review March 8, 2024 07:21

Changes were addressed in the PR description

@jeherve jeherve merged commit ad4c7bc into trunk Mar 8, 2024
52 of 54 checks passed
@jeherve jeherve deleted the require-wooanalytics-jetpack branch March 8, 2024 07:22
@github-actions github-actions bot added this to the jetpack/13.3 milestone Mar 8, 2024
jeherve added a commit that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] WooCommerce Analytics [Package] WooCommerce Analytics Enhanced analytics for WooCommerce users [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Woo Analytics: require the package in the Jetpack plugin and remove the code from the module.
3 participants