-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack AI: open AI Control upgrade link on new tab #37629
Jetpack AI: open AI Control upgrade link on new tab #37629
Conversation
…le for paid plans too
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
@@ -134,11 +137,16 @@ export function UpgradeMessage( { | |||
<span> | |||
{ sprintf( | |||
// translators: %1$d: number of requests remaining | |||
__( 'You have %1$d free requests remaining.', 'jetpack-ai-client' ), | |||
__( 'You have %1$d requests remaining.', 'jetpack-ai-client' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:oof3:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of #37458.
Proposed changes:
upgradeUrl
on the AI Control component (mainly the Extension AI Control), so we can provide an upgrade URL for the upgrade link, that will open on a new tabupgradeUrl
on the Extension AI Control, so the upgrade link on the extension will open on a new tabOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Testing the upgrade link on the error message:
public-api
so we can simulate a quota exceeded errorrun_query
method of the Jetpack AI Query class, add this line: