Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the protect-status package in the Protect plugin #37940

Merged
merged 14 commits into from
Jun 27, 2024

Conversation

elliottprogrammer
Copy link
Contributor

In this PR we are implementing use of the protect-status package that was created in #37894. Additionally, this PR can serve as a method of testing PR #37894.

Proposed changes:

  • Remove all occurrences of any protect-status related code.
  • Require and use the protect-status package.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

This PR is part of the PT: Add value to the active Protect product card on My Jetpack project: pbNhbs-aP6-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Create a Jurassic Ninja site with the Jetpack Beta Plugin, running Protect branch add/protect-status-pkg-to-plugin.
  • Connect Jetpack
  • Activate the Protect plugin and verify everything is working fine as expected, and with no errors.

@elliottprogrammer elliottprogrammer self-assigned this Jun 18, 2024
@elliottprogrammer elliottprogrammer changed the base branch from trunk to add/jetpack-protect-status-package June 18, 2024 20:21
@github-actions github-actions bot added [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Tests] Includes Tests Docs labels Jun 18, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Protect plugin:

  • Next scheduled release: July 2, 2024.
  • Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jun 18, 2024
@elliottprogrammer elliottprogrammer requested a review from a team June 18, 2024 20:47
Copy link
Contributor

@robertsreberski robertsreberski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor looks solid 💪

@@ -10,6 +10,7 @@
namespace Automattic\Jetpack\Protect;

use Automattic\Jetpack\Connection\Rest_Authentication as Connection_Rest_Authentication;
use Automattic\Jetpack\Protect_Status\REST_Controller as Status_REST_Controller;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could still keep it called Protect_Status_REST_Controller so it will be explicit in the code - what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree, Thanks Robert! 😃

Base automatically changed from add/jetpack-protect-status-package to trunk June 25, 2024 13:55
@elliottprogrammer elliottprogrammer dismissed robertsreberski’s stale review June 25, 2024 13:55

The base branch was changed.

Copy link
Contributor

@robertsreberski robertsreberski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good after the rebase 👍

@elliottprogrammer elliottprogrammer merged commit 52693fa into trunk Jun 27, 2024
53 checks passed
@elliottprogrammer elliottprogrammer deleted the add/protect-status-pkg-to-plugin branch June 27, 2024 13:48
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs [Package] Protect Status [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants