Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Scroll: ensure missing assets are loaded #37971

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

monsieur-z
Copy link
Contributor

@monsieur-z monsieur-z commented Jun 20, 2024

Fixes #12453

Proposed changes:

Let's consider a page containing a list of posts with infinite scroll enabled. As a user scrolls the page, a post item that's loaded on scroll and that contains a block may have missing styles. That's for instance the case of the Tiled Gallery block, whose layout is not respected in a list of posts.

Before After
Screenshot 2024-06-20 at 4 35 19 PM Screenshot 2024-06-21 at 11 00 52 AM

Images are stacked instead of being displayed as a grid

This PR ensures that, for posts loaded on scroll, the required assets are loaded.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Spin up a Jetpack site with this branch
  • Install and activate a theme that supports infinite scroll, such as Dara
  • In Jetpack > Settings > Writing (or go to /wp-admin/admin.php?page=jetpack#/settings?term=infinite), ensure that infinite scroll is enabled
  • You may need to delete widgets in footers (at /wp-admin/widgets.php) to make infinite scroll actually work
  • Create the necessary posts:
    • The fastest way is probably to ask me to export posts from my own test site; otherwise:
    • Create enough posts to have at least 2 pages of posts
    • Create a post that contains a Tiled Gallery block, and update its date so that it's rendered in the second page of posts
  • Visit a page of the site that contains a list of posts, such as the home page or a category page
  • Scroll the page
  • Ensure the post item containing the gallery is properly rendered
  • Optionally, test the PR with a simple and atomic site

Copy link
Contributor

github-actions bot commented Jun 20, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/infinite-scroll-missing-assets branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/infinite-scroll-missing-assets
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Infinite Scroll [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Jun 20, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for July 2, 2024 (scheduled code freeze on July 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@monsieur-z monsieur-z force-pushed the fix/infinite-scroll-missing-assets branch from 534819f to e1d7e7a Compare June 20, 2024 20:27
@monsieur-z monsieur-z marked this pull request as ready for review June 21, 2024 15:14
@monsieur-z monsieur-z requested a review from a team June 21, 2024 15:15
@monsieur-z monsieur-z self-assigned this Jun 21, 2024
@monsieur-z monsieur-z force-pushed the fix/infinite-scroll-missing-assets branch from e1d7e7a to 6cf6d69 Compare June 25, 2024 12:56
@monsieur-z monsieur-z force-pushed the fix/infinite-scroll-missing-assets branch from 6cf6d69 to 1b02341 Compare June 26, 2024 15:07
Copy link
Contributor

@chrisbliss18 chrisbliss18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to confirm the original issue on trunk with the images not tiling. After updating to this branch, the images tiled as expected.

The change looks good and works as intended on my test sites.

@monsieur-z monsieur-z merged commit 49960aa into trunk Jun 28, 2024
56 checks passed
@monsieur-z monsieur-z deleted the fix/infinite-scroll-missing-assets branch June 28, 2024 15:54
@github-actions github-actions bot added this to the jetpack/13.6 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Infinite Scroll [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiled Gallery Block / Infinite Scroll: galleries loaded via Infinite Scroll miss scripts and styles
2 participants