-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite Scroll: ensure missing assets are loaded #37971
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
534819f
to
e1d7e7a
Compare
e1d7e7a
to
6cf6d69
Compare
6cf6d69
to
1b02341
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to confirm the original issue on trunk
with the images not tiling. After updating to this branch, the images tiled as expected.
The change looks good and works as intended on my test sites.
Fixes #12453
Proposed changes:
Let's consider a page containing a list of posts with infinite scroll enabled. As a user scrolls the page, a post item that's loaded on scroll and that contains a block may have missing styles. That's for instance the case of the Tiled Gallery block, whose layout is not respected in a list of posts.
Images are stacked instead of being displayed as a grid
This PR ensures that, for posts loaded on scroll, the required assets are loaded.
Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
/wp-admin/admin.php?page=jetpack#/settings?term=infinite
), ensure that infinite scroll is enabled/wp-admin/widgets.php
) to make infinite scroll actually work