Fix more phan undeclared issues

[anomiex]

Proposed changes:

Mostly wpcomsh-related stuff this time.

• Fix some phpdocs and suppress some false positives.
• Add a stub file for woocommerce-payments plugin.
• Add a few Phan config 'parse_file_list' for wpcomsh functions.
• Remove some no-longer-needed suppressions.
• Remove some bogus suppressions:
  • Looks like \site_is_private() never existed, even in 4237ebc it was \Private_Site\site_is_private(). fixed in trunk now
  • Same for \site_is_coming_soon() and 263cf53.
• Remove references to some long-gone Gutenberg plugin functions.
  • gutenberg_can_edit_post_type, removed in 5.3.0 (2019) and core has had use_block_editor_for_post_type in wp-includes/post.php since 6.1.
  • gutenberg_get_block_template, removed in 15.8.0 (May 2023) and core has had get_block_template since 5.8.
• Use 'wpcom' stubs in wpcomsh, and add a manually-curated stub file for some Atomic stuff too.
• wpcomsh: Remove a use of extract().
• wpcomsh: Remove a plugin hotfix that said "remove after Gutenberg 15.3.x lands on WoA", which happened a while ago now.
• wpcomsh: Switch from Jetpack's Jetpack_WPCOM_Block_Editor class to jetpack-mu-wpcom's namespaced version.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

• CI happy?
• Stuff still works?

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/wpcomsh-phan-stuff branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/wpcomsh-phan-stuff
  

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/wpcomsh-phan-stuff
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for July 2, 2024 (scheduled code freeze on July 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Wpcomsh plugin:

• Next scheduled release: July 2, 2024.
• Scheduled code freeze: June 24, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.