-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack AI Image: handle enter shortcut on user custom prompt field #38103
Jetpack AI Image: handle enter shortcut on user custom prompt field #38103
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
bindGlobal | ||
shortcuts={ { | ||
enter: () => { | ||
if ( ! disableGenerateButton ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR:
disableGenerateButton
reads like a function. I would suggest changing it to generateButtonDisabled
. Same for the other variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pressing Enter once on a page with no content and no instructions do not trigger a generation, but it adds a newline, and then subsequent enters do trigger the generation.
My suggestion here is to consider the button disabled not only if there is no content, but also if there is only whitespace, as sending an empty request causes a 400
error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed both your feedbacks, renaming some vars and also trimming the content of the user prompt so remove extra spaces on it, so a field with only new lines can't be submitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice!
Closes #38102.
Proposed changes:
<KeyboardShortcuts />
wrapper on the user custom prompt field to deal withenter
hitsenter
, we trigger the image generation, unless there is no prompt typed on it (or no content on the post as well, when it's a featured image generation)AiImageModal
component so they read less like a function and more like the flags they reOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: