Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Boost: Enhance Image and CSS Proxy with CDN and Caching #38252

Merged
merged 11 commits into from
Jul 10, 2024

Conversation

pyronaur
Copy link
Member

@pyronaur pyronaur commented Jul 9, 2024

Proposed changes:

  • Implement CDN URL handling for image proxy requests.
  • Add content type validation and caching for CSS proxy requests.
  • Escape error messages for security enhancements.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

N/A

Testing instructions:

  • Use the image guide module to request an image and verify it's served through the Photon CDN.
  • Request a CSS file through the CSS proxy and check that it's cached.
  • Attempt to proxy a non-CSS file and confirm that they're not loaded

@github-actions github-actions bot added [Boost Feature] Critical CSS Issues involving the Critical CSS feature in Boost [Boost Feature] Image Guide [Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress labels Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Boost plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@pyronaur pyronaur changed the title Stricter proxy requests Jetpack Boost: Enhance Image and CSS Proxy with CDN and Caching Jul 9, 2024
@pyronaur pyronaur marked this pull request as ready for review July 9, 2024 07:42
@pyronaur pyronaur requested a review from a team July 9, 2024 07:56
dilirity
dilirity previously approved these changes Jul 9, 2024
Copy link
Member

@dilirity dilirity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical css generation works with remote stylesheets.

Just a note below, so we have this mentioned somewhere.

However, Image Guide doesn't (as is to be expected). We're no longer showing correct dimensions of images outside the photon domain.

Now

CleanShot 2024-07-09 at 12 26 48

Before

CleanShot 2024-07-09 at 12 27 17

Copy link
Contributor

@donnchawp donnchawp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Non image URLs are not proxied by IG Proxy, but images are, including "remote" images off another site.
CCSS files are still generated too.

@dilirity dilirity merged commit 3ce744a into trunk Jul 10, 2024
59 checks passed
@dilirity dilirity deleted the fix/boost/proxy branch July 10, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Boost Feature] Critical CSS Issues involving the Critical CSS feature in Boost [Boost Feature] Image Guide [Plugin] Boost A feature to speed up the site and improve performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants