Fixes the production build script. #4951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will now include a textdomain as well as include files one by one instead of using a built script making it easier to locate the string.
zinigor
added
[Type] Bug
zinigor
added
the
[Status] Needs Review
|
🚢 |
dereksmart
added
[Status] Ready to Merge
zinigor
removed
the
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
npm run build-productionworks well even without previous npm installations.i18n-calypsonow, giving us the opportunity to add the textdomain string.Testing instructions:
npm run build-script, note that it would take a lot of time and generate lots of new language files. The main thing that we're currently interested in is the_inc/jetpack-strings.phpfile, it should contain all the translatable strings from_inc/client/**/*.js*files.