New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widgets - Google Translate: change a PHP 5.4 array syntax, check if title is defined #5440
Merged
dereksmart
merged 8 commits into
master
from
fix/widgets-translate-undefined-title-array-syntax
Nov 8, 2016
Merged
Widgets - Google Translate: change a PHP 5.4 array syntax, check if title is defined #5440
dereksmart
merged 8 commits into
master
from
fix/widgets-translate-undefined-title-array-syntax
Nov 8, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliorivero
added
[Type] Bug
When a feature is broken and / or not performing as intended
[Feature] Extra Sidebar Widgets
[Status] In Progress
labels
Oct 28, 2016
artpi
force-pushed
the
fix/widgets-translate-undefined-title-array-syntax
branch
3 times, most recently
from
October 28, 2016 18:57
f78298d
to
a425d19
Compare
artpi
added
[Status] Needs Review
To request a review from Crew. Label will be renamed soon.
and removed
[Status] In Progress
labels
Oct 28, 2016
Thank you @eliorivero for these changes.
|
…2. Check if title is defined to avoid issuing a PHP notice in Customizer
artpi
force-pushed
the
fix/widgets-translate-undefined-title-array-syntax
branch
from
November 3, 2016 19:47
a64d6bd
to
b0f4883
Compare
zinigor
approved these changes
Nov 8, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, works good!
zinigor
added
[Status] Ready to Merge
Go ahead, you can push that green button!
and removed
[Status] Needs Review
To request a review from Crew. Label will be renamed soon.
labels
Nov 8, 2016
dereksmart
deleted the
fix/widgets-translate-undefined-title-array-syntax
branch
November 8, 2016 20:28
kraftbj
removed
the
[Status] Ready to Merge
Go ahead, you can push that green button!
label
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Extra Sidebar Widgets
[Pri] BLOCKER
Touches WP.com Files
[Type] Bug
When a feature is broken and / or not performing as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of major issues spotted in https://github.com/Automattic/jetpack/pull/5386/files
Changes proposed in this Pull Request:
Testing instructions:
make sure you can see PHP errors, go to Customizer, add the Google Translate widget. There should not be a PHP notice
when you update the widget in Customizer, make sure it's selectively refreshed, that is, only its portion is refreshed, rather than the whole page.
@artpi I was concerned about these two changes, so I opened this. You can continue adding other changes here.