Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes API: Fixed typo in "Themes_New" endpoint #5785

Merged
merged 1 commit into from Dec 1, 2016

Conversation

benyaminshoham
Copy link
Contributor

Class name is Jetpack_JSON_API_Themes_New_Endpoint but usage was using "new" with a lowercase N. Fixed to uppercase.
Since class names are case insensitive in PHP (http://stackoverflow.com/questions/5260168/capital-letters-in-class-name-php) there should be no effect on functionality, only coding standards.

Class name is Jetpack_JSON_API_Themes_new_Endpoint but usage was using "new" with a lowercase N. Fixed to uppercase.
@jeherve jeherve added [Feature] WPCOM API [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Bug When a feature is broken and / or not performing as intended labels Dec 1, 2016
@jeherve jeherve added this to the 4.4.2 milestone Dec 1, 2016
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@jeherve
Copy link
Member

jeherve commented Dec 1, 2016

Related: #5537

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Dec 1, 2016
@zinigor zinigor merged commit dd2361a into master Dec 1, 2016
zinigor pushed a commit that referenced this pull request Dec 1, 2016
Class name is Jetpack_JSON_API_Themes_new_Endpoint but usage was using "new" with a lowercase N. Fixed to uppercase.
@zinigor
Copy link
Member

zinigor commented Dec 1, 2016

Ported to branch-4.4 in bdb832e.

@kraftbj kraftbj deleted the fix/themes-new-endpoint-typo branch July 13, 2017 04:49
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] WPCOM API [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants