Set is_feed/feed so sitemap can be identified later in shutdown #7397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions. Caching plugins will be able to query is_feed() and then check the query variable "feed" for the type of feed before creating a cache file of the sitemap. See https://github.com/Automattic/wp-super-cache/issues/237 for further discussion.
dereksmart
added
[Feature] Sitemaps
[Status] Needs Review
eliorivero
added
[Status] Ready to Merge
|
thanks @donnapep! |
eliorivero
pushed a commit
that referenced
this pull request
Jul 1, 2017
…ions. (#7397) Caching plugins will be able to query is_feed() and then check the query variable "feed" for the type of feed before creating a cache file of the sitemap. See https://github.com/Automattic/wp-super-cache/issues/237 for further discussion.
|
Cherry picked to 5.1 in 0c9e922 |
kraftbj
removed
the
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify sitemaps as a "sitemap" feed for the purposes of caching or further analysis of an output buffer.
Caching plugins use output buffering to capture the page so even though the sitemap function dies immediately after the content is pushed out, the content is still captured. However, in my testing the Content-Type header was not captured (even when using
apache_get_header_listorheaders_list) in the output buffer callback. With this change the caching plugin can identify a sitemap and then use the right caching and/or content type. This is how WP Super Cache does that.See https://github.com/Automattic/wp-super-cache/issues/237 for further
discussion.