Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top Posts: display the default title when it is set to false. #7763

Merged
merged 1 commit into from Sep 27, 2017
Merged

Top Posts: display the default title when it is set to false. #7763

merged 1 commit into from Sep 27, 2017

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Sep 7, 2017

Fixes #7402

When you want to see the default title in the widget, let's display it.

Testing instructions:

  • Add a Top Posts Widget to your sidebar.
  • Set a custom title for that widget, ensure it gets saved and displayed on the site and in the widget setting screen.
  • Now change that title to "Top Posts & Pages"
  • When saving your changes, make sure the title doesn't disappear from the widget settings.

Proposed changelog entry for your changes:

  • Top Posts Widgets: display the default title when it is set to false.

@jeherve
Top Posts: display the default title when it is set to false.
c38623e 
Fixes #7402

When you want to see the default title in the widget, let's display it.
@jeherve jeherve added [Feature] Extra Sidebar Widgets [Pri] Low [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Bug When a feature is broken and / or not performing as intended labels Sep 7, 2017
@jeherve jeherve self-assigned this Sep 7, 2017
@jeherve jeherve requested a review from a team as a code owner September 7, 2017 12:01
@jeherve jeherve mentioned this pull request Sep 7, 2017
Closed
dereksmart
dereksmart approved these changes Sep 25, 2017
View reviewed changes
Copy link
Member

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Sep 25, 2017
@zinigor zinigor merged commit cda1d68 into master Sep 27, 2017
@zinigor zinigor deleted the fix/top-posts-no-display-default branch September 27, 2017 04:35
jeherve added a commit that referenced this pull request Oct 6, 2017
@jeherve
Changelog: add #7763
45c9438
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereksmart dereksmart dereksmart approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Extra Sidebar Widgets [Pri] Low Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Widgets: Top Posts & Pages deletes own title in wp-admin
5 participants
@jeherve @dereksmart @kraftbj @zinigor @matticbot