Gutenblock: Jetpack Subscription Form #7769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgestephanis
added
the
[Feature] Subscriptions
georgestephanis
force-pushed
the
gutenberg/subscription-block
branch
from
ad09d04
to
ee4803f
Compare
dereksmart
force-pushed
the
gutenberg/subscription-block
branch
from
e6b8367
to
7069c52
Compare
lamosty
force-pushed
the
gutenberg/subscription-block
branch
4 times, most recently
from
8400704
to
2dde4bf
Compare
… Form. Gutenblooooock Pull it out to an external js file. Dummy jsx file to start with. Unit tests: if `register_block_type` isn't defined Just quit out, they don't have Gutenberg installed.
Fixed it! Happy GM! Subscription form block - updated styles Subscription form block - minor style changes
Add source to title and subscribe_text attrs
Ran prettier on the block.jsx file Make the subscribe_text into textarea so it's editable Refactor the variables to be camelCase Add Editable to subscribeText Add "show total number of subscribers" setting to sidebar Add Subscribe Button and Success Message TextControl(s) Use SSR to render the subscription form Remove 'shortcode' lib dependency Disable the email field and submit button
Use textarea for the subscribe_text Content of Editable can't be saved as JSON and used with SSR.
lamosty
force-pushed
the
gutenberg/subscription-block
branch
from
2dde4bf
to
e772e26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial once through for creating a Gutenberg Block based on the Jetpack Subscription Form.
The js should probably get yanked to its own file and done in es6, but this works for now and saves an additional file to sync and transpile.
CheckboxControl doesn't seem to update. I may be missing something there.
Apart from that, seems to work.