Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Payments: do not render trashed products #7853

Merged

Conversation

lamosty
Copy link
Member

@lamosty lamosty commented Sep 25, 2017

If a Simple Payments product is trashed, it is still displayed on a post/page. This PR fixes that by filtering posts with the trash status.

WP.com counterpart D6739-code

Testing

Create a post with a Simple Payment button. Go to wp-admin of your site, open wp_posts table and change the status of the Simple Payments button "post" row from published to trash. The button should not show when navigating to the front-end of the post anymore.

@lamosty lamosty requested a review from a team as a code owner September 25, 2017 16:24
Copy link
Contributor

@donpark donpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lamosty lamosty merged commit 3771406 into simple-payments/update-2 Sep 25, 2017
@lamosty lamosty deleted the fix/simple-payments-hide-trashed-buttons branch September 25, 2017 16:27
@jeherve jeherve added Simple Payments [Type] Bug When a feature is broken and / or not performing as intended labels Sep 26, 2017
@jeherve jeherve added the [Feature] Pay with PayPal aka Simple Payments label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Pay with PayPal aka Simple Payments [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants