Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of create_function so PHP 7.2 does not complain #8478

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Remove usage of create_function so PHP 7.2 does not complain #8478

merged 2 commits into from
Jan 11, 2018

Commits on Jan 6, 2018

  1. Replace usage of create_function in checksum_histogram function from … 

    …Sync ReplicaStore test
    @oskosk
    oskosk committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    ceb6da9 View commit details
    Browse the repository at this point in the history

  2. Replace usage of create_function in get_post_meta_by_id and get_comme… 

    …nt_meta_by_id functions from Sync ReplicaStore test

It’s weird to have to maintain PHP 5.2 and PHP 7.2 compatibility in
these cases as we can’t create anonymous functions and use $meta_id in
the filtering function. A one-liner becomes a monster.
    @oskosk
    oskosk committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    07adefb View commit details
    Browse the repository at this point in the history