Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailchimp Widget: avoid conflicts with jQuery UI #8547

Merged

Commits on Jan 17, 2018

  1. Fix issue Automattic#8546 - remove window.require and window.define f…

    …rom global scope after using a require definition
    adamziel committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    a0966bb View commit details
    Browse the repository at this point in the history
  2. Fix issue Automattic#8546 - instead of removing window.require and wi…

    …ndow.define from global scope and thus breaking mailchimp script, set window.define.amd to fool just real amd modules.
    
    Mailchimp script seem to expect usable definitions of require and define, once we remove them it breaks. Since the purpose of this commit is to fix scripts like jquery-ui that will resort to define() if define.amd is defined - it is enough to unset define.amd. This is a very ugly solution, but it works.
    adamziel committed Jan 17, 2018
    Configuration menu
    Copy the full SHA
    c609360 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2018

  1. Update mailchimp shortcode test to match earlier fix for issue Automa…

    …ttic#8546 - test for updated script string.
    adamziel committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    129234a View commit details
    Browse the repository at this point in the history