Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WordAds shortcode name #9440

Merged
merged 2 commits into from
Apr 30, 2018
Merged

Update WordAds shortcode name #9440

merged 2 commits into from
Apr 30, 2018

Conversation

rclations
Copy link
Contributor

This PR updates the Jetpack Ads shortcode name from [wordad] to [wordads].

@rclations rclations added this to the 6.1 milestone Apr 27, 2018
@rclations rclations self-assigned this Apr 27, 2018
@rclations rclations requested a review from a team as a code owner April 27, 2018 22:02
@rclations rclations requested a review from oskosk April 27, 2018 22:03
Copy link
Member

@roccotripaldi roccotripaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship't

@rclations rclations added the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 27, 2018
@rclations rclations changed the base branch from branch-6.1-built to master April 30, 2018 14:46
@rclations rclations force-pushed the update/wordads-shortcode-name branch from 7e57094 to 86de402 Compare April 30, 2018 14:49
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 30, 2018
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk merged commit 3c3949d into master Apr 30, 2018
@oskosk oskosk deleted the update/wordads-shortcode-name branch April 30, 2018 18:01
oskosk pushed a commit that referenced this pull request Apr 30, 2018
* WordAds: Update shortcode name

* Update comments to state `wordads` instead of `wordad` for the shortcode name
@oskosk
Copy link
Contributor

oskosk commented Apr 30, 2018

Ported to branch-6.1 in db6b3d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants