Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing: update function to properly handle the sharing module #997

Merged
merged 2 commits into from
Aug 12, 2014

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Aug 12, 2014

  1. Concatenate the frontend sharing stylesheet
    • sharing is the stylesheet added to the sharing settings screen
    • sharedaddy is added to the frontend
  2. Add a conditional to handle disabled sharing css option
    • The option can be set under Settings > Sharing, and uses the sharedaddy_disable_resources option

cc @blobaugh and @MichaelArestad

'sharing' is the stylesheet added to the sharing settings screen
'sharedaddy' is added to the frontend
The option can be set under Settings > Sharing
uses the sharedaddy_disable_resources option
@jeherve jeherve added this to the 3.2 milestone Aug 12, 2014
blobaugh added a commit that referenced this pull request Aug 12, 2014
Sharing: update function to properly handle the sharing module
@blobaugh blobaugh merged commit be90035 into Automattic:css-reorg Aug 12, 2014
@blobaugh blobaugh deleted the css-reorg branch August 12, 2014 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Sharing Post sharing, sharing buttons General [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants