New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPCOM_Liveblog handle_request() is hooked to template_redirect, generating warnings #620

Open

paulschreiber opened this issue Jan 24, 2019 · 0 comments

Contributor

paulschreiber commented Jan 24, 2019

In WPCOM_Liveblog, handle_request() is hooked to template_redirect. This is generating warnings:

Is this intentional? Can we move handle_request() to a different filter or action?

  330 | WARNING | Please, make sure that a callback to `'template_redirect'` filter is returning void intentionally.
      |         | (WordPressVIPMinimum.Filters.AlwaysReturn.voidReturn)
  330 | WARNING | Please, make sure that a callback to `'template_redirect'` filter is always returning some value.
      |         | (WordPressVIPMinimum.Filters.AlwaysReturn.missingReturnStatement)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment