fix(document): save newly set defaults underneath single nested subdocuments #13002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12905
Summary
If
applyDefaults()creates a default underneath a single nested subdocument when loading from MongoDB, a subsequentsave()won't save that default. This is a quick fix that handles that particular case. It won't handle nested subdocuments, or subdocuments underneath arrays, because that's proven to be a bit trickier. However, this PR should be enough to unblock OP from #12905 with minimal risk, and we can improve change tracking in this case later.Examples