Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Rethink how "msm_sitemap_update_last_run" works #77
I noticed something that is perhaps a non-issue, but want to draw attention in case it could become and issue. Along with my work in #76, I've been working on a way of initially deploying the plugin where I have more control over the sitemap generation. I got myself into a state where the cron events would no longer flag a site creation event. To reproduce:
I find it interesting that when I try to generate the site maps manually, but don't finish, that the cron updater does not notice this. This is because
I am only logging this issue because response has been pretty positive to #76. We need to make sure that if we implement a manual generation mode that we maybe rethink
If we do switch to a cli driven initial generation as per #76 then it makes sense to indicate a level of progress perhaps per year completed in the dashboard.
It probably makes sense to keep the two process (update and initial generation) separate otherwise we could be in a situation where an initial generation fails and the update process then creates the large amount of cron events that we were trying to avoid.
@tollmanz is there a reason you use the script in 3 rather than
Was just thinking that this could be used to track the progress of initial generation even if it's only on each year completed
This makes sense. This is mostly a note to self that this will become and issue if we move forward with something like #76. We would need to make sure that the UX makes all of this clear.
This was a @mjangda suggestion. It seems safe to complete smaller chunks of work at a time and if I need to stop the process, I can then manipulate the loop when starting again to ignore certain month/year combinations. Additionally, I was thinking I might put in some timeouts in the loop in order to reduce server load if needed.