Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow attributes to be added to Doubleclick AMP ad units' markup #55

Closed
dero opened this issue Jul 20, 2020 · 1 comment
Closed

Allow attributes to be added to Doubleclick AMP ad units' markup #55

dero opened this issue Jul 20, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@dero
Copy link

dero commented Jul 20, 2020

Currently, the AMP markup for doubleclick ad units has a firm structure that doesn't allow 3rd parties to change the generated markup (AFAIK, let me know if this is incorrect).

In our case we're running a native AMP site and would like to create a child theme and change the units' markup to potentially contain rtc-config and / or data-multi-size attributes to increase ad demand competition, but we're unable to easily do so.

Would it be possible to make the generated AMP ad unit string filterable? Or do you consider a filter like that to be too powerful and we should look for other options?

@kmwilkerson kmwilkerson added the enhancement New feature or request label Nov 30, 2021
@kmwilkerson kmwilkerson modified the milestones: Milestone 5: Sitewide Ads Template, Milestone 6: Increased Flexibility of AMP Ads Jan 24, 2022
@kmwilkerson kmwilkerson removed this from the Milestone 7: Increased Flexibility of AMP Ads milestone Jun 29, 2022
@kmwilkerson
Copy link
Contributor

Closing this issue as Newspack is in the process of moving away from AMP

@kmwilkerson kmwilkerson closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants