Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(woocommerce-memberships): membership status check #3338

Merged
merged 2 commits into from
Aug 14, 2024
Merged

fix(woocommerce-memberships): membership status check #3338

merged 2 commits into from
Aug 14, 2024

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Fixes an issue introduced in #3268. Memberships were switched to active status too eagerly, causing free-trial memberships to become active under certain conditions.

How to test the changes in this Pull Request:

  1. On release, update an active membership (with an active subscription attached) to wcm-free_trial status
  2. Load the Memberships view (/wp-admin/edit.php?post_type=wc_user_membership), reload
  3. Observe the membership's status was updated to wcm-active
  4. Switch to this PR and update the status again to wcm-free_trial
  5. Repeat step 2 – observe the status was not changed

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Aug 14, 2024
@adekbadek adekbadek requested a review from a team as a code owner August 14, 2024 09:07
@miguelpeixe
Copy link
Member

I'm about to review this now, could you change the base to release?

miguelpeixe
miguelpeixe approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@miguelpeixe miguelpeixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find the "Free trial" option but switching to "Complimentary" had the same effect.

Works as described.

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Aug 14, 2024
@adekbadek adekbadek changed the base branch from trunk to release August 14, 2024 19:11
@adekbadek @leogermani
Update includes/plugins/wc-memberships/class-memberships.php
d2de8af 
Co-authored-by: leogermani <leogermani@automattic.com>
@leogermani leogermani merged commit d424f53 into release Aug 14, 2024
8 checks passed
@leogermani leogermani deleted the hotfix/memberships-issue branch August 14, 2024 21:25
matticbot pushed a commit that referenced this pull request Aug 14, 2024
@semantic-release-bot
chore(release): 5.0.1 [skip ci]
a88783d 
## [5.0.1](v5.0.0...v5.0.1) (2024-08-14)

### Bug Fixes

* **woocommerce-memberships:** membership status check ([#3338](#3338)) ([d424f53](d424f53))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 5.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dkoo dkoo mentioned this pull request Aug 29, 2024
Merged
6 tasks
@adekbadek adekbadek mentioned this pull request Sep 5, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelpeixe miguelpeixe miguelpeixe approved these changes

@leogermani leogermani leogermani left review comments

Assignees
No one assigned
Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adekbadek @miguelpeixe @matticbot @leogermani