Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2: PHP Notice for breathe_color_styles() #206

Open
grappler opened this issue Jan 4, 2021 · 0 comments
Open

P2: PHP Notice for breathe_color_styles() #206

grappler opened this issue Jan 4, 2021 · 0 comments

Comments

@grappler
Copy link

grappler commented Jan 4, 2021

I hope this is the right place to report a PHP Notice with p2-breathe

I am getting the following PHP Notice with Revision 57498.

Trying to access array offset on value of type bool in inc/customizer.php line 61, 62, 64 & 65

The reason for this is this code. The get_theme_mod() is returning false by default when no settings have been saved and isset() is checking if the variable is null.

	$options = get_theme_mod( 'breathe_theme_options', null );

	if ( ! isset( $options ) )
		return;

A possible solution would be

	$options = get_theme_mod( 'breathe_theme_options', null );

	if ( ! $options )
		return;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant