Fix: zoom shortcuts on numeric keypad #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belcherj
approved these changes
Oct 21, 2020
codebykat
force-pushed
the
fix/zoom-numpad
branch
from
4234ae9
to
c507db6
Compare
|
Rebased and switched to roles to match #2406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This fixes #2400, a report that these shortcuts only work when triggered from the top keyboard row, and not from the number pad.
In my testing on OSX, the only one that did not work was Zoom In. But based on the report I've also added additional shortcuts to handle Zoom Out (Ctrl + minus) and Default view (Ctrl + zero).
See:
Test
Release
Fixed a bug preventing zoom level shortcuts from being triggered by keys on the numeric keypad