-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix appx builds #920
Fix appx builds #920
Conversation
This reverts commit 687edd1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested a build on Windows Store and it worked great (but is x86, which may actually be better for us). As discussed can you add another signed .appx build that we can test locally?
@roundhill you now have 3 build jobs for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adlk! once conflicts are resolved!
This PR splits the Appveyor CI builds into two separate steps as the binaries that are being used to generate the appx package needs to be unsigned.
Default
generates the signed binaries and the signed NSIS .exe installerAppX
generates an unsigned binary and appx packageIf the binary is signed prior to creating the appx – the publisher info for the appx is being pulled from the certificate instead of the provided
publisher
config fromelectron-builder-appx.json