Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appx builds #920

Merged
merged 19 commits into from
Nov 12, 2018
Merged

Fix appx builds #920

merged 19 commits into from
Nov 12, 2018

Conversation

adlk
Copy link
Contributor

@adlk adlk commented Oct 16, 2018

This PR splits the Appveyor CI builds into two separate steps as the binaries that are being used to generate the appx package needs to be unsigned.

  • Default generates the signed binaries and the signed NSIS .exe installer
  • AppX generates an unsigned binary and appx package

If the binary is signed prior to creating the appx – the publisher info for the appx is being pulled from the certificate instead of the provided publisher config from electron-builder-appx.json

Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a build on Windows Store and it worked great (but is x86, which may actually be better for us). As discussed can you add another signed .appx build that we can test locally?

@adlk
Copy link
Contributor Author

adlk commented Oct 30, 2018

@roundhill you now have 3 build jobs for

  • signed production build (.exe)
  • unsigned Windows Store build (.appx)
  • signed Windows Store test build (.appx)

Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adlk! :shipit: once conflicts are resolved!

@adlk adlk merged commit 3852d85 into master Nov 12, 2018
@adlk adlk deleted the fix/appx-config branch November 12, 2018 15:19
@adlk adlk restored the fix/appx-config branch November 13, 2018 14:07
@adlk adlk deleted the fix/appx-config branch November 13, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants