Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Odd Text Selection #921

Closed
jleandroperez opened this issue Oct 15, 2020 · 1 comment · Fixed by #982
Closed

Editor: Odd Text Selection #921

jleandroperez opened this issue Oct 15, 2020 · 1 comment · Fixed by #982
Assignees
@jleandroperez
Labels
bug Something isn't working. [feature] editor Anything related to the editor.
Milestone
4.28

Comments

@jleandroperez
Copy link
Contributor

jleandroperez commented Oct 15, 2020 •
edited
Loading

Steps:

  1. Open a long document
  2. Tap anywhere to reveal the keyboard
  3. Tap anywhere at the bottom of the visible text

As a result, the cursor will be relocated, and the pressed line will be slighly scrolled upwards.
Thank you @aerych for spotting this!!

I've tracked this issue down to the SPEditorTextView.adjustedContentInsets overridden API.

References: #806 #916
@jleandroperez jleandroperez added bug Something isn't working. [feature] editor Anything related to the editor. labels Oct 15, 2020
@jleandroperez jleandroperez self-assigned this Nov 2, 2020
This was referenced Nov 2, 2020
Merged
Merged
@jleandroperez jleandroperez added this to the 4.28 milestone Nov 3, 2020
@jleandroperez
Copy link
Contributor Author

Update:

Text Selection is still a bit odd. Autoscroll should only happen whenever the selected row is partially not visible.

This was referenced Nov 4, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleandroperez jleandroperez

Labels
bug Something isn't working. [feature] editor Anything related to the editor.
Projects
None yet
Milestone
4.28
Development

Successfully merging a pull request may close this issue.

Fixing Text Selection: Mark III Automattic/simplenote-ios
1 participant
@jleandroperez