Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fixing iOS 14 Autoscroll Bug #916

Merged
merged 23 commits into from
Oct 15, 2020

Conversation

jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Oct 13, 2020

Fix

This PR fixes an iOS 14 scroll bug, that causes the TextView to jump over to the "previously selected" location instead.

@aerych I'm sorry to trouble you with this one sir!!

Please let me know about literally anything odd you might notice. Would be super if tested on iOS 12/13/14!!

Closes #888

Scenario 1:

  1. Open a long document that requires vertical scrolling
  2. Tap on top
  3. Scroll all the way to the bottom
  • Verify the cursor shows up at the spot where you've pressed
  • Verify the vertical offset doesn't jump back to the former cursor's location
  • Verify the inverse: while the caret is at the bottom, scroll to the top and tap anywhere please!

Scenario 2:

  1. Open a long document that requires vertical scrolling, and has multiple checklists at the bottom
  2. Tap on top
  3. Scroll all the way to the bottom
  • Verify that pressing over a Checklist at the bottom does not cause the editor to jump back to the top
  • Verify that right after pressing over any Checklist Item the cursor appears at the end of the Item's Line
  • Verify tapping over multiple Items in a row does not cause the contextual UIMenuController to show up

Scenario 3:

  1. Scroll to the bottom
  2. Long press over any checklist
  • Verify nothing odd happens!

Scenario 4:

  • Verify double tap over any word highlights it
  • Verify long press over Links while in readonly mode works fine
  • Verify dragging the cursor all over works as expected (and it's not impossible to control!)

Release

RELEASE-NOTES.txt was updated in 730f898 with:

Fixed a bug that affected scrolling in iOS 14 #916


Sample Document!!

Welcome to Simplenote for iOS!

To add a note, tap the plus button.

Flick the list to browse your noes. Tap a title to view a note, then tap its contents to change it.

You can search all your notes by typing in the search field at the top of the note list.

Tap the arrow button at the top left or swipe across your note list to view your tags. You can add tags to a note at the bottom of the note editor, and then use the sidebar to help you stay organized.

There are more note options if you need them. You can add others as collaborators to a note, or publish a note as a web page.

Use Simplenote on your Mac, Android device, or in your web browser at http://simplenote.com. Your notes will stay updated everywhere automatically.


To add a note, tap the plus button.

Flick the list to browse your notes. Tap a title to view a note, then tap its contents to change it.

You can search all your notes by typing in the search field at the top of the note list.

Tap the arrow button at the top left or swipe across your note list to view your tags. You can add tags to a note at the bottom of the note editor, and then use the sidebar to help you stay organized.

There are more note options if you need them. You can add others as collaborators to a note, or publish a note as a web page.

Use Simplenote on your Mac, Android device, or in your web browser at http://Simplenote.com. Your notes will stay updated everywhere automatically.

- [ ] Uno
- [ ] Dos
- [ ] Tres
- [ ] Cuatro
- [ ] Catorce!

everywhere automatically

@jleandroperez jleandroperez added bug Something isn't working. [priority] high Fix/Feature needed as soon as possible. labels Oct 13, 2020
@jleandroperez jleandroperez added this to the 4.25.1 milestone Oct 13, 2020
@jleandroperez jleandroperez self-assigned this Oct 13, 2020
@jleandroperez jleandroperez changed the base branch from develop to release/4.25.1 October 13, 2020 19:27
@jleandroperez jleandroperez changed the title Editor: Prevents re-applying the same Bottom Insets Editor: Fixing iOS 14 Autoscroll Bug Oct 13, 2020
@peril-automattic
Copy link

peril-automattic bot commented Oct 14, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@jleandroperez jleandroperez marked this pull request as ready for review October 14, 2020 22:59
@jleandroperez jleandroperez modified the milestones: 4.25.1, 4.26 ❄️ Oct 14, 2020
@jleandroperez
Copy link
Contributor Author

Moving to 4.26!

@jleandroperez jleandroperez changed the base branch from release/4.25.1 to release/4.26 October 14, 2020 23:03
Copy link
Member

@aerych aerych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @jleandroperez 👋
Test scenarios all pass and the code changes (apart from the commented stuff we were testing) looks sharp.
I spotted some oddities that we chatted about but those are existing/different things.
:shipit: when ready sir!

@jleandroperez
Copy link
Contributor Author

Thanks A LOT for killing this one @aerych!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. [priority] high Fix/Feature needed as soon as possible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigating/Scrolling issue on iOS14
2 participants