New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg Compatibility #10

Open

trepmal opened this issue Jun 2, 2021 · 0 comments

Labels

Contributor

trepmal commented Jun 2, 2021

Not strictly a Gutenberg/Block Editor problem, but that does make it vastly easier to create incompatible headings.

The regex only matches plain tags:

table-of-contents/table-of-contents.php

Line 129 in 5b3da29

    
           preg_match_all( "/(<{$tag}>)(.*)(<\/{$tag}>)/", $content, $matches, PREG_SET_ORDER );

Any attributes added such as alignment mean the regex won't "find" the heading tag to add to the TOC.

trepmal added the enhancement label

trepmal mentioned this issue

The h4 headings are not listed in the toc generated #4

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment