Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid themes using normalize.css - Remove unused code for IE10 because conflicts with the image border added via editor #7925

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

miksansegundo
Copy link
Contributor

@miksansegundo miksansegundo commented Jul 4, 2024

Changes proposed in this Pull Request:

For Hybrid themes using normalize.css

  • Remove unused code for IE10 because it conflicts with the image border added via the editor.

The affected themes are: alves, balasana, barnsbury, brompton, calm-business, _normalize.scss, coutoire, dalston, elegant-business, exford, friendly-business, hever, leven, mayland, maywood, modern-business, morden, photos, professional-business, redhill, rivington, rockfield, seedlet/assets/sass/base, shawburn, sophisticated-business, stow, an stratford.

I am not sure how/where Sass builds the css for these themes, so I'm removing the code from all files just to be safe.

Related issue(s):

#7896

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Preview changes

I've detected changes to the following themes in this PR: Professional Business, Maywood, Alves, Photos, Elegant Business, Shawburn, Rockfield, Coutoire, Brompton, Stow, Stratford, Exford, Morden, Seedlet, Mayland, Modern Business, Rivington, Sophisticated Business, Redhill, Balasana, Calm Business, Hever, Barnsbury, Dalston, Leven, Friendly Business.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

⚠️ Note: Child themes are dependent on their parent themes. You will have to install the parent theme as well for the preview to work correctly.

@miksansegundo miksansegundo merged commit 480266e into trunk Jul 4, 2024
3 checks passed
@miksansegundo miksansegundo deleted the fix/image-border-in-hybrid-themes branch July 4, 2024 11:46
This was referenced Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant