Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inversum: add theme #7862

Closed
wants to merge 2 commits into from
Closed

Inversum: add theme #7862

wants to merge 2 commits into from

Conversation

henriqueiamarino
Copy link
Collaborator

@henriqueiamarino henriqueiamarino commented Jun 17, 2024 •
edited
Loading

Inversion is a blog theme designed in the WordPress Site Editor. Its neat visuals introduce a direct experience on post reading: noticeable post titles listed on a text-only page, with an original swap of header and footer blocks.
Demo site

screenshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 17, 2024 •
edited
Loading

Preview changes

I've detected changes to the following themes in this PR: Russell, Professional Business, Sunderland, Maywood, Alves, Farrow, Loïc, Otis, Meraki, Photos, Elegant Business, Shawburn, Rockfield, Coutoire, Brompton, Inversum, Stow, Stratford, Vitrum, Artly, Hall, Exford, Morden, Attar, Seedlet, Mayland, Modern Business, Rivington, Sophisticated Business, Dorna, Redhill, Balasana, Appleton, Calm Business, Hever, Heiwa, Barnsbury, Dalston, Marl, Varia, Erma, Leven, Friendly Business.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

⚠️ Note: Child themes are dependent on their parent themes. You will have to install the parent theme as well for the preview to work correctly.

@henriqueiamarino
Copy link
Collaborator Author

henriqueiamarino commented Jul 1, 2024 •
edited
Loading

@jasmussen This one, the Upsidedown, has also been reviewed many times. It might be quicker to submit it to the Dotorg review queue.

@jasmussen
Copy link
Member

Nice, I love this one. The demo text may be a bit over the top, but it's fun!

Very few pieces on this one. I immediately noticed that these things don't fully line up:
Screenshot 2024-07-04 at 11 32 10

Maybe they don't have to?

I'm not sure why, but in the site editor, and only there, there's no top padding on the site:

Screenshot 2024-07-04 at 11 33 45

Love the style variations, I especially like the swedish one, and the dark Noir one. Again a thing for future variations, some typography changes might be nice too.

Readme looks good, templates look good, mobile looks good. Nice one.

@henriqueiamarino
Copy link
Collaborator Author

henriqueiamarino commented Jul 4, 2024 •
edited
Loading

Thanks, @jasmussen. Yes, I've been noticing these misalignments in many themes. I conclude that something has changed in our Layout settings, whether Inner blocks use (or not) content width.
Not a big problem, though. I have a quick fix for them.

Would you recommend any topic for a demo content change?

@henriqueiamarino
Copy link
Collaborator Author

I am closing this PR and deleting the branch as I commit unwanted changes. I'll create a new PR.
This is probably related to issue #7925

@henriqueiamarino henriqueiamarino deleted the add/inversum branch July 4, 2024 15:50
@henriqueiamarino henriqueiamarino mentioned this pull request Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henriqueiamarino @jasmussen @iamarinoh