Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIP does not return a proper response code #599

Open
nbcsteveb opened this issue Oct 27, 2020 · 3 comments
Open

VIP does not return a proper response code #599

nbcsteveb opened this issue Oct 27, 2020 · 3 comments
Labels
[Status] Keep Prevent the "stale" workflow from auto-closing

Comments

@nbcsteveb
Copy link

nbcsteveb commented Oct 27, 2020

Expected/Desired Behavior

The status code returned by wp should be properly set, this helps with command chaining or handling failures.

$ wp ajsodjasiodjsaiod
Error: 'ajsodjasiodjsaiod' is not a registered wp command. See 'wp help' for available commands.

$ echo $?
1

$ vip @app.env wp ajsodjasiodjsaiod
Error: 'ajsodjasiodjsaiod' is not a registered wp command. See 'wp help' for available commands.

$ echo $?
1

Actual Behavior

$ wp ajsodjasiodjsaiod
Error: 'ajsodjasiodjsaiod' is not a registered wp command. See 'wp help' for available commands.

$ echo $?
1

$ vip @app.env wp ajsodjasiodjsaiod
Error: 'ajsodjasiodjsaiod' is not a registered wp command. See 'wp help' for available commands.

$ echo $?
0

Steps to Reproduce the Problem

  1. Step 1: Run a vip @app.env wp command that throws an error or otherwise returns an error status code through standard WP CLI.
  2. Step 2: Check the returned status code, and notice it is always "0".
@uxcitizen
Copy link

Hi Steve,

Thanks for reporting this bug! I've added it to our internal bug tracker, and we will take a look!

@github-actions
Copy link
Contributor

This issue has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep issues manageable and actionable and is not a comment on the quality of this issue nor on the work done so far. Closed issues are still valuable to the project and are available to be searched.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2022
@jblz jblz reopened this Nov 21, 2022
@jblz jblz added [Status] Keep Prevent the "stale" workflow from auto-closing and removed [Status] Autoclosed [Status] Stale labels Nov 21, 2022
@plovinicius
Copy link

I was looking for some open source project to contribute, what is the expected output here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Keep Prevent the "stale" workflow from auto-closing
Projects
None yet
Development

No branches or pull requests

4 participants