Stream Wrapper: Tweaks to vip files update-filesizes script
#1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way we store the filesize and avoid future lookups.
Just to be sure :)
Script won't work without it.
Much faster than really large LIMITs especially when using an index.
mjangda
changed the title
vip files update-filesizes script
End the loop only after we've finished going through all IDs. Also kills the progress bar which isn't great for seeing ongoing progress on really large sites.
hanifn
reviewed
Mar 8, 2019
|
|
||
| $max_id = $wpdb->get_var( 'SELECT ID FROM ' . $wpdb->posts . ' ORDER BY ID DESC LIMIT 1' ); | ||
|
|
||
| $end_index = $start_index + $batch_size; |
There was a problem hiding this comment.
Are we at all concerned about how accurate the $end_index would be? It is very likely that the post ID will not be sequential
There was a problem hiding this comment.
With the way it's written, we just loop through all post IDs until we hit the highest one. We will probably have batches where there are 0 results or 0 attachments but that's okay.
|
r133803-deploy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of optimizations and improvements:
And a few other small changes.
Checklist
Please make sure the items below have been covered before requesting a review: