Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream Wrapper: Tweaks to vip files update-filesizes script #1173

Merged
merged 8 commits into from
Mar 12, 2019
Merged

Stream Wrapper: Tweaks to vip files update-filesizes script #1173

merged 8 commits into from
Mar 12, 2019

Commits on Mar 7, 2019

  1. Output log file for easier tracking

    @mjangda
    mjangda committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    dee2589 View commit details
    Browse the repository at this point in the history

  2. If attachment has no meta, we should create it 

    That way we store the filesize and avoid future lookups.
    @mjangda
    mjangda committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    240ae2b View commit details
    Browse the repository at this point in the history

  3. Add a confirmation prompt 

    Just to be sure :)
    @mjangda
    mjangda committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    6115f66 View commit details
    Browse the repository at this point in the history

  4. Add check for Stream Wrapper 

    Script won't work without it.
    @mjangda
    mjangda committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    ab5de8c View commit details
    Browse the repository at this point in the history

  5. Use BETWEEN instead of LIMIT 

    Much faster than really large LIMITs especially when using an index.
    @mjangda
    mjangda committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    d234cd1 View commit details
    Browse the repository at this point in the history

  6. Allow skipping prompt with --yes

    @mjangda
    mjangda committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    a5df1dd View commit details
    Browse the repository at this point in the history

  7. Don't fail if we have a batch with no attachments 

    End the loop only after we've finished going through all IDs.

Also kills the progress bar which isn't great for seeing ongoing
progress on really large sites.
    @mjangda
    mjangda committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    e5fb21b View commit details
    Browse the repository at this point in the history

  8. Allow overriding start-index to allow resumes

    @mjangda
    mjangda committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    7a43d53 View commit details
    Browse the repository at this point in the history