Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header info to app output #223

Merged
merged 4 commits into from
Dec 21, 2018
Merged

Add header info to app output #223

merged 4 commits into from
Dec 21, 2018

Conversation

elazzabi
Copy link
Member

This adds general info as a header info when using the vip app <id> command.

Before:

┌────────────────┬────────────┬────────────┬────────────────┬─────────────────────┐
│ name           │ repo       │ branch     │ current commit │ primary domain      │
├────────────────┼────────────┼────────────┼────────────────┼─────────────────────┤
│ <redacted>     │ <redacted> │ <redacted> │ aabbccd        │ <redacted>          │
├────────────────┼────────────┼────────────┼────────────────┼─────────────────────┤
│ <redacted>     │ <redacted> │ <redacted> │ aabbccd        │ <redacted>          │
├────────────────┼────────────┼────────────┼────────────────┼─────────────────────┤
│ <redacted>     │ <redacted> │ <redacted> │ aabbccd        │ <redacted>          │
├────────────────┼────────────┼────────────┼────────────────┼─────────────────────┤
│ <redacted>     │ <redacted> │ <redacted> │ aabbccd        │ <redacted>          │
└────────────────┴────────────┴────────────┴────────────────┴─────────────────────┘

After:

===================================
+ id: <redacted>
+ name: <redacted>
+ repo: <redacted>
===================================
┌────────────────┬────────────┬────────────────┬─────────────────────┐
│ name           │ branch     │ current commit │ primary domain      │
├────────────────┼────────────┼────────────────┼─────────────────────┤
│ <redacted>     │ <redacted> │ aabbccd        │ <redacted>          │
├────────────────┼────────────┼────────────────┼─────────────────────┤
│ <redacted>     │ <redacted> │ aabbccd        │ <redacted>          │
├────────────────┼────────────┼────────────────┼─────────────────────┤
│ <redacted>     │ <redacted> │ aabbccd        │ <redacted>          │
├────────────────┼────────────┼────────────────┼─────────────────────┤
│ <redacted>     │ <redacted> │ aabbccd        │ <redacted>          │
└────────────────┴────────────┴────────────────┴─────────────────────┘

Steps to test:

  1. clone this branch
  2. run npm link
  3. run vip app <id> or vip app <name>

fixes #168

Copy link
Member

@mjangda mjangda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! 🎉

@elazzabi elazzabi merged commit fbfb91b into master Dec 21, 2018
@elazzabi elazzabi deleted the add/app-header branch December 21, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistency between app <id> and app list
2 participants