Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken comment avatars #697

Open
aadilayub opened this issue Feb 15, 2024 · 4 comments
Open

Broken comment avatars #697

aadilayub opened this issue Feb 15, 2024 · 4 comments
Labels
Needs triage Stale [Type] Bug Something isn't working

Comments

@aadilayub
Copy link

Quick summary

Avatars on activitypub comments become broken after the URL for the user's avatar changes on Mastodon's side.

Specifically, the first comment on this post.

image

The avatar used to load before, but now it's broken.

Steps to reproduce

I'm not sure how to give instructions to reproduce this, since it requires that someone else comments on your site and the URI for their avatar changes.

What you expected to happen

Every comment has a functional avatar. In the absence of an avatar, a fallback placeholder avatar is used.

What actually happened

When the comment author's avatar is not reachable, it results in a broken image on your site.

Impact

One

Available workarounds?

No but the platform is still usable

Logs or notes

Looking at the HTML, the comment by my friend uses this URL for the avatar:

https://sunbeam.city/system/accounts/avatars/000/038/480/original/a12605bee7e9406e.jpg

When I go to their profile on Mastodon and click inspect element on their avatar, I see that the actual URI for their avatar is

https://sunbeam.city/system/accounts/avatars/000/038/480/original/73da25f84ad489a3.jpg

@aadilayub aadilayub added [Type] Bug Something isn't working Needs triage labels Feb 15, 2024
@janboddez
Copy link
Contributor

janboddez commented Feb 16, 2024

Related: #568.

That issue was closed because there is a follower update cron. (I noticed the issue in the context of followers' avatars.)

Not sure if a "commenter updater" is feasible. Storing them locally is what I do now, for a default duration of one month. Which people may not like, because it won't immediately reflect changes made on their end. (In fact, I think I may never update old comments. I'm not too sure anymore.) And so on.

Interested to hear about a better solution.

@aadilayub
Copy link
Author

Is there a workaround to manually edit/update the avatar?

@janboddez
Copy link
Contributor

The URL, I believe, is stored in a custom meta field (or custom post field). If you know a bit of SQL, it could be updated that way (but it is rather tedious).

There are other ways, but nothing easy. (I personally use a custom add-on plugin that fetches the avatar and stores it locally, and overwrites the aforementioned custom field with the "local" URL.)

I was initially also thinking of an extra field on the "Edit Comment screen" where one could view and possibly even edit the URL, but I'm afraid future versions of the plugin will make it harder to even access this screen (for "Fediverse comments," at least, the reasoning being that site admins shouldn't be able to just go and change other people's [remote] replies).

Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage Stale [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants