Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update admin-menu reducer to be keyed by siteID #45511

Closed
getdave opened this issue Sep 9, 2020 · 1 comment
Closed

Update admin-menu reducer to be keyed by siteID #45511

getdave opened this issue Sep 9, 2020 · 1 comment
Assignees
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.

Comments

@getdave
Copy link
Contributor

getdave commented Sep 9, 2020

This is a Sub Issue of #45435

Depends on #45495.

Once D49005-code is transformed to be a site-specific endpoint (@obenland are you able to help here?) we need to update the reducer introduced in #45495 so that the data is keyed by siteId.

The fetch query should return this information from the API endpoint once it is updated and then will need to be fed back through the data-layer handler function into the action in order that siteId is available in the reducer.

Once in place it's a matter of updating the reducer to use the keyedReducer helper - it will look similar to something like this:

export default keyedReducer( 'siteId', adminMenu );
@getdave getdave added the [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. label Sep 9, 2020
@getdave getdave self-assigned this Sep 9, 2020
@getdave
Copy link
Contributor Author

getdave commented Sep 14, 2020

This ended up being handled in #45495

@getdave getdave closed this as completed Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Development

No branches or pull requests

1 participant