Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Unification - implement conditionals for static fallback nav data #45910

Closed
getdave opened this issue Sep 24, 2020 · 3 comments · Fixed by #46785
Closed

Nav Unification - implement conditionals for static fallback nav data #45910

getdave opened this issue Sep 24, 2020 · 3 comments · Fixed by #46785
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task

Comments

@getdave
Copy link
Contributor

getdave commented Sep 24, 2020

Sub Issue of #45435

Once #45836 is merged we will have a static copy of a basic admin menu which we can use to render instantly as the user loads Calypso.

However, there are certain conditions that determine which items should/shouldn't be shown to a user. These need to be implemented within the "static" data. Placeholders already exist, but the conditional logic needs to be written.

@getdave getdave added [Type] Task [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. labels Sep 24, 2020
@getdave
Copy link
Contributor Author

getdave commented Sep 24, 2020

@obenland Is it worth tackling this at this stage? It's another level of detail and could take a while.

@obenland
Copy link
Member

We can probably backload that.

@mreishus
Copy link
Contributor

I haven't done all of the different flags, just a couple, but requesting a look+review before sinking more time into this. #46785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants