Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav unification - allow sidebar to be scrolled (while maintaining flyout menus) #46643

Closed
frontdevde opened this issue Oct 21, 2020 · 3 comments
Assignees
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task

Comments

@frontdevde
Copy link
Contributor

Note: This is a separate issue for a task that was previously part of #46094.

--

We recently merged the first iteration of flyout menus in #46046 (comment). One of the known issues, that we'll have to address next:

Scrolling inside the scrollbar vs scrolling the sidebar with the page

Right now in Calypso the sidebar container is position:fixed and it's overflow content (i.e. more nav items than screen height) is scrollable. This is achieved by adding overflow:auto to the sidebar. The issue is that overflow:auto prevents overflow content i.e. the flyout from being visible.

We removed the overflow:auto on the sidebar for flyout menus to be visible in the nav unification prototype. This has two side effects: a) the sidebar container isn't scrollable anymore and b) when using the site switcher, the overflow is visible when selecting a site.

wp-admin gets around the first issue by not having a scrollable sidebar container but instead adjusting the sidebar positioning via JS based on scroll state. The second issue is not present in wp-admin as there's no in-page site switcher.

@frontdevde frontdevde added [Type] Task [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. labels Oct 21, 2020
@cpapazoglou cpapazoglou self-assigned this Oct 21, 2020
@cpapazoglou
Copy link
Contributor

After merging #46689 we just need to make the transition from the site-switcher back to the menu smoother by hiding the overflowing menu till transition is over

This is what is happening currently:
SS 2020-11-02 at 15 45 28

@getdave
Copy link
Contributor

getdave commented Nov 2, 2020

After merging #46689 we just need to make the transition from the site-switcher back to the menu smoother by hiding the overflowing menu till transition is over

Should we make a dedicated Issue for that so it's easier to track what is left to complete? Or does it fit nicely within this Issue?

@cpapazoglou
Copy link
Contributor

Done Transition from the site-switcher back to the menu animation. Updated the master issue too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task
Projects
None yet
Development

No branches or pull requests

3 participants