Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading Settings: Clean up temporary hasTranslation checks #73000

Closed
2 tasks done
ivan-ottinger opened this issue Feb 6, 2023 · 2 comments · Fixed by #73239
Closed
2 tasks done

Reading Settings: Clean up temporary hasTranslation checks #73000

ivan-ottinger opened this issue Feb 6, 2023 · 2 comments · Fixed by #73239
Assignees
@ivan-ottinger
Labels
Maintenance Reading Settings Issues related to Reading Settings page in calypso

Comments

@ivan-ottinger
Copy link
Contributor

ivan-ottinger commented Feb 6, 2023 •
edited

Some of our PRs, i.e.:

add temporary hasTranslation checks. These should be removed once the strings in the above PRs are translated.
@ivan-ottinger ivan-ottinger added [Type] Task Reading Settings Issues related to Reading Settings page in calypso labels Feb 6, 2023
@mashikag mashikag mentioned this issue Feb 10, 2023
Merged
7 tasks
@mashikag mashikag self-assigned this Feb 10, 2023
@mashikag mashikag reopened this Feb 10, 2023
@mashikag mashikag removed their assignment Feb 10, 2023
@ivan-ottinger
Copy link
Contributor Author

#73040 is now translated as well → We can remove the hasTranslation checks from the related code as well.

@ivan-ottinger ivan-ottinger self-assigned this Jan 23, 2024
@ivan-ottinger
Copy link
Contributor Author

This is now done. → Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivan-ottinger ivan-ottinger

Labels
Maintenance Reading Settings Issues related to Reading Settings page in calypso
Projects
None yet
Milestone
No milestone
3 participants
@TimBroddin @mashikag @ivan-ottinger