Reading Settings: Remove translation check for the label of the default value of the 'Default posts page' input

[mashikag]

Resolves #73000

Proposed Changes

• since the translation process is complete (see here), it is now safe to remove the translation check with the fallback to the old label

Testing Instructions

• Go to https://wordpress.com/settings/reading
• Ensure the label of the default value of the 'Default posts page' input is "— None —"

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-56974

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-56974&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~30 bytes removed 📉 [gzipped])

name              parsed_size           gzip_size
settings-reading       -112 B  (-0.0%)      -30 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[ivan-ottinger]

I see the strings introduced in the other PR (#73040) hasn't been translated yet. If I understand correctly, you would like to address each of the PRs mentioned in the task (#73000) separately, right?

In that case, we could keep the #73000 task opened until the other language check is removed as well. 🙂

[mashikag]

If I understand correctly, you would like to address each of the PRs mentioned in the task (#73000) separately, right?

Correct. :)

In that case, we could keep the #73000 task opened until the other language check is removed as well. 🙂

Yes, I will make sure to reopen the task, and I will mark it as Blocked until the other translations are in. :)

[ivan-ottinger]

The changes look good. 👍🏼 There's just one issue that is causing a JS error:

[ivan-ottinger]

Looks good and works as expected. 🙂👍🏼

• Tested with multiple locales set. Correct translation is used.
• I did not observe any errors / warnings nor regressions.

[ivan-ottinger]

The Unit tests are failing, but I cannot open the Details for some reason. 🤔
→ Got in and restarted them.

[mashikag]

The Unit tests are failing, but I cannot open the Details for some reason. 🤔
→ Got in and restarted them.

🙇‍♂️