New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reading Settings: Rename 'Default posts page' default option to 'None' #72709
Reading Settings: Rename 'Default posts page' default option to 'None' #72709
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~76 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works as expected. 🙂👍🏼
One thing we should consider though is the translation. If we are launching next week, the translation of the new string won't be ready:
Because of that we can consider adding conditional that will display the old string until the new one is ready. Example: 2ee9f-pb - video at 1:30 timestamp.
Great point @ivan-ottinger, and thank you for pointing me to the learning source too (I have bookmarked it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point @ivan-ottinger, and thank you for pointing me to the learning source too (I have bookmarked it
♥️ )!
My pleasure! 🙂
Code looks good and works as expected - tested with English and Spanish locales.
English displays the "new" —— None ——
string, Spanish displays the "old" (already translated) —— Select ——
string.
I did not observe any regression nor errors / warnings. Tested with Simple, Atomic and Jetpack self-hosted site.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7787479 Thank you @mashikag for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
Testing Instructions
http://calypso.localhost:3000/settings/reading/$site
Pre-merge Checklist
Fixes #72603