Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading Settings: Rename 'Default posts page' default option to 'None' #72709

Conversation

mashikag
Copy link
Contributor

@mashikag mashikag commented Jan 27, 2023

Proposed Changes

  • Rename 'Default posts page' default option to 'None'

Testing Instructions

  • Go to http://calypso.localhost:3000/settings/reading/$site
  • Ensure the default option displays "None" instead of "Select"
    Screen Shot 2023-01-27 at 12 52 13

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Fixes #72603

@mashikag mashikag requested a review from a team January 27, 2023 11:54
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 27, 2023
@mashikag mashikag self-assigned this Jan 27, 2023
@matticbot
Copy link
Contributor

matticbot commented Jan 27, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~76 bytes added 📈 [gzipped])

name              parsed_size           gzip_size
settings-reading       +234 B  (+0.1%)      +76 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works as expected. 🙂👍🏼

One thing we should consider though is the translation. If we are launching next week, the translation of the new string won't be ready:

Markup on 2023-01-27 at 14:59:39

Because of that we can consider adding conditional that will display the old string until the new one is ready. Example: 2ee9f-pb - video at 1:30 timestamp.

@mashikag
Copy link
Contributor Author

Great point @ivan-ottinger, and thank you for pointing me to the learning source too (I have bookmarked it ♥️)!

@ivan-ottinger ivan-ottinger self-requested a review January 30, 2023 22:33
Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point @ivan-ottinger, and thank you for pointing me to the learning source too (I have bookmarked it ♥️)!

My pleasure! 🙂

Code looks good and works as expected - tested with English and Spanish locales.

English displays the "new" —— None —— string, Spanish displays the "old" (already translated) —— Select —— string.

I did not observe any regression nor errors / warnings. Tested with Simple, Atomic and Jetpack self-hosted site.

@mashikag mashikag merged commit d0d8a47 into trunk Feb 1, 2023
@mashikag mashikag deleted the update/reading-settings-default-posts-page-default-option-rename branch February 1, 2023 11:52
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 1, 2023
@a8ci18n
Copy link

a8ci18n commented Feb 1, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7787479

Thank you @mashikag for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Feb 10, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading Settings: Display "— None —" instead of "— Select —" for "Default posts page" setting
4 participants