Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcodes not working on FSE themes #77001

Closed
adelineyaw opened this issue May 17, 2023 · 14 comments
Closed

Shortcodes not working on FSE themes #77001

adelineyaw opened this issue May 17, 2023 · 14 comments
Labels
[Closed] By design Behaviors that are functioning as designed. Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Platform] Atomic [Pri] Normal [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@adelineyaw
Copy link

Quick summary

When third party shortcodes are used within the Editor (FSE Theme), the shortcodes appear as text only.

All relevant plugins were updated and activated at the time.

Work-around: The shortcodes work on a regular Post/Page. For example, if the shortcodes are used on a homepage, you'll want to re-create the homepage within a Page.

Steps to reproduce

  1. Activate a FSE Theme
  2. Add shortcode within the Editor
  3. Preview page
  4. Code can be seen on the page

What you expected to happen

I expect to see results from the third party shortcode.

What actually happened

I see text only code.

Impact

Most (> 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Atomic

Logs or notes

No response

@adelineyaw adelineyaw added [Type] Bug User Report This issue was created following a WordPress customer report labels May 17, 2023
@adelineyaw
Copy link
Author

User report: 42655115-hc

Work-around resolved this issue.

Theme: Blank Canvas

@inaikem
Copy link
Contributor

inaikem commented May 17, 2023

Closing this issue for now since it's expected behaviour following the WP 6.2.1 release and associated May 12th WPcom update: p1683882880050879-slack-CB0B2G43X .

Cc: @cuemarie

@inaikem inaikem closed this as completed May 17, 2023
@arinoch
Copy link

arinoch commented May 17, 2023

For posterity, adding report 43360805-hc as also having this issue.

@inaikem, do you know if this is a temporary stopgap or the permanent fix? I suspect mine and @adelineyaw's interactions aren't going to be the only two.

@inaikem
Copy link
Contributor

inaikem commented May 17, 2023

Thanks James. My current understanding is this is a permanent change made in Core (WP 6.2.1). We deployed a related update to WPcom several days ahead of the Core release, which has since made its way to WPcom, too.

Pinging @xknown for clarification and any additional context.

@cuemarie
Copy link

Workaround

Wrapping the Shortcode in a Template Part allows it to load. Tested with [portfolio] on a simple site and some [smart slider xyz] shortcode on a user's Atomic site and it worked in both places. Hattip @liviopv for digging that up!

@ariel-maidana
Copy link

Adding for posterity: 6299446-zd-woothemes

@github-actions
Copy link

github-actions bot commented May 17, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • 6299446-zen
  • 6306041-zen
  • 6289140-zen
  • 7363867-zen

@arinoch
Copy link

arinoch commented May 17, 2023

Adding for posterity: 43438059-hc

@Greatdane
Copy link

Adding another affected user; 43347556-hc

@poeticabdul
Copy link

Another user 35013727-hc

@dev-sabbir
Copy link

dev-sabbir commented May 19, 2023

Another user 6306041-zd-woothemes

@daria2303
Copy link

6289140-zd-woothemes

@JoshuaGoode
Copy link

6.2.2 was released to WPCloud/Atomic over the weekend, which fixes this regression (restoring the use of shortcodes in block templates) while also resolving the vulnerability

Simple sites still have a patch that will continue to prevent shortcodes in block templates but Atomic doesn't. (edited)

Note that 6.2.2 can break/affect the visuals of certain shortcodes as the HTML output is modified -- adding

and
tags.
https://core.trac.wordpress.org/ticket/58366

@pak-cia
Copy link

pak-cia commented Nov 27, 2023

+1 - 7363867-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Nov 27, 2023
@cuemarie cuemarie added the [Closed] By design Behaviors that are functioning as designed. label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] By design Behaviors that are functioning as designed. Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Platform] Atomic [Pri] Normal [Type] Bug User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests