Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill create_function #91005

Closed
TimBroddin opened this issue May 22, 2024 · 2 comments
Closed

Polyfill create_function #91005

TimBroddin opened this issue May 22, 2024 · 2 comments

Comments

@TimBroddin
Copy link
Contributor

Polyfilling create_function in WPCOMSH should fix some sites.

See: https://github.com/php5friends/polyfill-create_function

@obenland
Copy link
Member

One of the things to consider with this is that we'll have to keep that polyfill forever.

We wouldn't know which sites it effects (including sites that become dependent on it after we merge it), so removing it would be very painful.

Not necessarily a blocker, but a circumstance we should acknowledge if this is what we decide to do.

@obenland
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants