Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout: add summary business plan features (4) #42854

Merged
merged 4 commits into from
Jun 2, 2020

Conversation

michaeldcain
Copy link
Member

This is a first step towards adding plan-specific features to the Checkout summary. It adds the following features to the summary when a 1- or 2-year business plan is in the cart:

  • Free domain for one year (when a domain isn't in the cart)
  • Install plugins and themes
  • Drive traffic to your site with our advanced SEO tools
  • Track your stats with Google Analytics

Screen Shot 2020-06-01 at 1 59 19 PM

To test:

  • add a business plan to your cart and visit Checkout with ?flags=composite-checkout-testing
  • verify that the checkout summary has the added features
  • switch plan variation and verify that the features remain
  • add a domain and verify that the "Free domain for one year" feature is removed (a separate domain item should be seen)

@michaeldcain michaeldcain added the [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. label Jun 1, 2020
@michaeldcain michaeldcain requested review from fditrapani and a team June 1, 2020 18:08
@michaeldcain michaeldcain self-assigned this Jun 1, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Jun 1, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~209 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
checkout       +674 B  (+0.0%)     +209 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@fditrapani
Copy link
Contributor

I tested this with multiple plans and this looks great! Thanks for the updates!

@nbloomf
Copy link
Contributor

nbloomf commented Jun 2, 2020

Here are my test results.

  • personal plan only:

Screen Shot 2020-06-02 at 11 55 40 AM

  • business plan only (1 year):

Screen Shot 2020-06-02 at 11 56 52 AM

  • business plan only (selected 2 year):

Screen Shot 2020-06-02 at 11 57 32 AM

  • business plan with domain (2 years):

Screen Shot 2020-06-02 at 11 59 44 AM

  • business plan with domain (selected 1 year):

Screen Shot 2020-06-02 at 12 00 07 PM

@nbloomf nbloomf self-requested a review June 2, 2020 17:02
@michaeldcain michaeldcain merged commit 9d25b62 into master Jun 2, 2020
@michaeldcain michaeldcain deleted the add/checkout-summary-business-plan-features branch June 2, 2020 18:12
@a8ci18n
Copy link

a8ci18n commented Jun 2, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3745278

Thank you @michaeldcain for including a screenshot in the description! This is really helpful for our translators.

@michaeldcain michaeldcain changed the title Checkout: add summary business plan features Checkout: add summary business plan features (4) Jun 5, 2020
nbloomf pushed a commit that referenced this pull request Jun 9, 2020
In #42854 we added plan features to the Checkout summary for the business plan. This adds features for all active WordPress.com plans.
@a8ci18n
Copy link

a8ci18n commented Jun 11, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants