-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout: add summary features for each of the WP.com plans (1) #43080
Conversation
return [ | ||
! hasDomainsInCart && translate( 'Free domain for one year' ), | ||
translate( 'Remove WordPress.com ads' ), | ||
translate( 'Limit your content to paying subscribers.' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 18 times:
translate( 'Limit content to paying subscribers.' )
ES Score: 9
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~320 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Cain you are supposed to be on vacation! All combinations of plan+domain show the expected lists of features -- nice work. |
Seriously! Looks good to me too. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3786479 Hi @michaeldcain, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
We added plan-specific feature lists in #43080 but forgot to prevent the free domain feature from being displayed on renewals; this PR fixes that. Co-authored-by: nbloomf <nathan.bloomfield@automattic.com>
Translation for this Pull Request has now been finished. |
In #42854 we added plan features to the Checkout summary for the business plan. This adds features for all active WordPress.com plans.
All Plans:
Personal:
Premium:
Business:
Ecommerce:
To test:
?flags=composite-checkout-testing