Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch restore progress details from /restore endpoint #47212

Merged
merged 2 commits into from
Nov 7, 2020

Conversation

monsieur-z
Copy link
Contributor

@monsieur-z monsieur-z commented Nov 6, 2020

Changes proposed in this Pull Request

This PR is a sequel of #47153. It retrieves data from a different endpoint in order to show more granular percentage and to display the entry being restored.

Testing instructions

  • Run this PR in Calypso or Jetpack cloud
  • Select a self-hosted Jetpack site that has a Backup product, and more than one backup
  • Make sure you have set server credentials to enable restores
  • Visit the Backup section, select a backup to restore, and click Restore to this point, the Confirm restore
  • Check that you see the message and current entry returned by the API, respectively above and below the progress bar
  • Make sure the order of messages makes sense and that there's no big jump in the progress bar

@monsieur-z monsieur-z added Rewind [Feature] Backups The Jetpack Backup product labels Nov 6, 2020
@monsieur-z monsieur-z requested a review from a team November 6, 2020 22:28
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 6, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Nov 6, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~10 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main        +30 B  (+0.0%)      +10 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~21 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
backup         +823 B  (+0.2%)      +32 B  (+0.0%)
activity       +670 B  (+0.1%)      -11 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~21 bytes added 📈 [gzipped])

name                                    parsed_size           gzip_size
async-load-signup-steps-rewind-migrate        +34 B  (+0.1%)       +7 B  (+0.1%)
async-load-signup-steps-clone-ready           +34 B  (+0.1%)       +7 B  (+0.1%)
async-load-signup-steps-clone-point           +34 B  (+0.0%)       +7 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@elliottprogrammer elliottprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @monsieur-z ! Works great! Code looks great!
LGTM! 🚢

@elliottprogrammer elliottprogrammer merged commit 81db137 into master Nov 7, 2020
@elliottprogrammer elliottprogrammer deleted the improve/restore-progress-change-endpoint branch November 7, 2020 01:43
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Backups The Jetpack Backup product Rewind
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants