Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State: Remove unused rewind progress selectors #52097

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Apr 20, 2021

Changes proposed in this Pull Request

This PR removes a couple of rewind progress selectors that are no longer in use since #47212.

Testing instructions

Verify the removed selectors are no longer in use.

@tyxla tyxla added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial State Rewind labels Apr 20, 2021
@tyxla tyxla requested review from a team April 20, 2021 10:02
@tyxla tyxla self-assigned this Apr 20, 2021
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@rcanepa rcanepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Everything still works fine and selectors are definitely not being used anywhere in the codebase.

@tyxla tyxla merged commit 436ab62 into trunk Apr 21, 2021
@tyxla tyxla deleted the remove/unused-rewind-progress-selectors branch April 21, 2021 07:04
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants