-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change wordings and a bit of style for p2 creation #60640
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -383,7 +383,7 @@ class P2Site extends Component { | |
className="p2-site__validation-site-title" | ||
> | ||
<FormLabel htmlFor="site-title-input"> | ||
{ this.props.translate( 'Name your team' ) } | ||
{ this.props.translate( 'Name your workspace' ) } | ||
</FormLabel> | ||
<FormTextInput | ||
id="site-title-input" | ||
|
@@ -404,7 +404,7 @@ class P2Site extends Component { | |
className="p2-site__validation-site" | ||
> | ||
<FormLabel htmlFor="site-address-input"> | ||
{ this.props.translate( 'Choose an address for your P2 workspace' ) } | ||
{ this.props.translate( 'Choose an address for your workspace' ) } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🆗 This change will be queued for retranslation. We'll use the existing translations in the meantime. |
||
</FormLabel> | ||
<div className="p2-site__site-url-container"> | ||
<FormTextInput | ||
|
@@ -461,11 +461,13 @@ class P2Site extends Component { | |
render() { | ||
return ( | ||
<P2StepWrapper | ||
className="p2-site__create" | ||
flowName={ this.props.flowName } | ||
stepName={ this.props.stepName } | ||
positionInFlow={ this.props.positionInFlow } | ||
headerText={ this.props.translate( | ||
'Share, discuss, review, and collaborate across time zones, without interruptions.' | ||
headerText={ this.props.translate( 'Create a workspace' ) } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 19 times: |
||
subHeaderText={ this.props.translate( | ||
'Your workspace is where you will create all the different P2s for teams, projects, topics, etc.' | ||
) } | ||
> | ||
<form className="p2-site__form" onSubmit={ this.handleSubmit } noValidate> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗 This change will be queued for retranslation. We'll use the existing translations in the meantime.