Enhance SplitPropertyPath to conditionally handle parentheses in prop… #16054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
|
@cla-avalonia agree |
Abdesol
force-pushed
the
issue-15865-fix
branch
2 times, most recently
from
9a96785
to
4f0a969
Compare
|
You can test this PR using the following package version. |
|
Could we get a failing/passing test combo in this PR to make reviewing easier, and to ensure we don't regress? See contributing for more information. |
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Parenthesis encircles the property type in front of properties in a property path. Example
(Contact).Name. TheSplitPropertyPathmethod from ReflectionHelper could not handle this, making datagrid cells automatically uneditable when there is a cast of property type in the path. Now, I am conditionally handling that, and the issue is resolved by removing the property type cast from the property path.What is the current behavior?
property casting happens in a property path and automatically makes the datagrid cell uneditable when it is there.
What is the updated/expected behavior with this PR?
If there is a cast of a property type with parenthesis on the property path, it is removed from the path, and there is no making it uneditable because of that issue
Fixed issues
Fixes #15865